Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions builders/server/core/service/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import core.db.datasets
from core.runtime import registry
from core.service.orchestrator import run_build
from core.service.store import MemoryStore, PostgresStore
from core.service.timestamps import NoValidTimestampsError, generate_timestamps
from core.utils.semver import SemVer

Expand Down Expand Up @@ -35,9 +36,17 @@ def build_dataset(
dataset_version: SemVer,
start: datetime,
end: datetime,
) -> None:
*,
dry_run: bool = False,
) -> dict[datetime, list[dict]] | None:
"""Public entrypoint for building a dataset and its dependencies."""
run_build(dataset_name, dataset_version, start, end)
if not dry_run:
run_build(dataset_name, dataset_version, start, end, store=PostgresStore())
return None

store = MemoryStore()
run_build(dataset_name, dataset_version, start, end, store=store)
return store.get_rows_range(dataset_name, dataset_version, start, end)


def get_data(
Expand Down
36 changes: 31 additions & 5 deletions builders/server/tests/core/service/test_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,38 @@ def test_generate_timestamps_start_on_closed_day_no_valid_range_returns_empty()

@patch("core.service.builder.run_build")
def test_build_dataset_delegates_to_orchestrator(mock_run_build: MagicMock) -> None:
"""build_dataset delegates to run_build with the same args."""
build_dataset("ds", V010, datetime(2024, 1, 1), datetime(2024, 1, 5))
"""build_dataset delegates to run_build with a PostgresStore for real builds."""
from core.service.store import PostgresStore

mock_run_build.assert_called_once_with(
"ds", V010, datetime(2024, 1, 1), datetime(2024, 1, 5)
)
result = build_dataset("ds", V010, datetime(2024, 1, 1), datetime(2024, 1, 5))

assert result is None
mock_run_build.assert_called_once()
args, kwargs = mock_run_build.call_args
assert args == ("ds", V010, datetime(2024, 1, 1), datetime(2024, 1, 5))
assert isinstance(kwargs["store"], PostgresStore)


@patch("core.service.builder.run_build")
def test_build_dataset_dry_run_uses_memory_store_and_returns_rows(
mock_run_build: MagicMock,
) -> None:
"""dry_run build uses a MemoryStore and returns the produced rows."""
from core.service.store import MemoryStore

ts = datetime(2024, 1, 1)

# simulate the worker writing into the injected store during the build
def fake_run_build(name, version, start, end, store):
store.insert_rows(name, version, [(ts, [{"v": 1}])])

mock_run_build.side_effect = fake_run_build

result = build_dataset("ds", V010, ts, ts, dry_run=True)

assert result == {ts: [{"v": 1}]}
store = mock_run_build.call_args.kwargs["store"]
assert isinstance(store, MemoryStore)


@patch("core.service.builder.run_build")
Expand Down
Loading