Sync with the latest wasi-proposal-template#24
Conversation
https://github.com/WebAssembly/wasi-proposal-template commit 6601e1064e381370f4f66d1db2d0ccaa006220b6
|
an alternative to #23 |
| /// Short description | ||
| /// | ||
| /// Explanation for developers using the API. | ||
| api-function-one: function() -> api-type-one |
There was a problem hiding this comment.
Why do these templates live in the proposal itself? Shouldn't it be instances of the templates that live here? (apologies I've not be following the proposal template stuff).
i.e. shouldn't the templates get renamed when a proposal is started?
There was a problem hiding this comment.
i guess we should rename them when we start using them.
this PR is meant to be the minimum ci fix.
i personally prefer to remove them until we actually start using them: #23
There was a problem hiding this comment.
No, I was just curious. This pr seems fine.
loganek
left a comment
loganek
left a comment
There was a problem hiding this comment.
That looks fine to me as a quick fix; I guess we could now also provide the actual definitions?
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
I'm fine with this too but I think what I meant by my original comment (wherever I made it) was that we should just write out the WIT for wasi-threads since it is quite simple. This makes CI green, though, so one of us can do that in a future PR... Thanks for fixing this!
4 participants
https://github.com/WebAssembly/wasi-proposal-template
commit 6601e1064e381370f4f66d1db2d0ccaa006220b6