Always set display=true when calling NRF.setSecurity.#24
Open
cmumford wants to merge 1 commit intoWebBluetoothCG:mainfrom
Open
Always set display=true when calling NRF.setSecurity.#24cmumford wants to merge 1 commit intoWebBluetoothCG:mainfrom
cmumford wants to merge 1 commit intoWebBluetoothCG:mainfrom
Conversation
If the `passkey` option is true then so must `display`. This does not mean that the device needs to have a display - only that the passkey is somehow displayed to the user for device identification. This is only a test, so hard-code to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
passkeyoption is true then so mustdisplay. This doesnot mean that the device needs to have a display - only that the
passkey is somehow displayed to the user for device identification.
This is only a test, so hard-code to true.