Set correct order of params#12
Conversation
|
Apparently this is not backwards compatible. Order of params changed from 2.2.1 to 2.2.2. Do you want this to be backwards compatible with CMB2 2.2.1 and below? |
|
Yes, we'll want to try and find a backwards compatibility fix. I agree, suddenly changing the order of parameters for a method is not the correct way to handle this. |
|
As a followup after having looked things over more closely. I'll say we want to avoid backcompat breaking whenever possible. However, I don't think this spot is one that the user ever touches, or sets something somewhere that'd dictate anything order-related here. I think we'd be fine to change this without hassle. @jtsternberg what do you think? |
|
its been a year, but shouldn't this plugin keep in sync with cmb2? every time i use this plugin, i have to change that line to fix the warning. |
3 participants
See #10