Skip to content

Improve Benchmark constructor and instance variables #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camillobruni merged 6 commits into from
Jan 14, 2026
Merged

Improve Benchmark constructor and instance variables #255

camillobruni merged 6 commits into from
Jan 14, 2026

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 14, 2026 •
edited
Loading

  • Use plan as options bag for constructor arguments
  • Prefix "protected" instance variables with "_"
  • Rename Benchmark.preload to Benchmark._preloadEntries
  • Move iteration and worstCase count processing to the Benchmark class
  • Add files and preloadEntries getters so we can override it in GroupedBenchmark
  • Rename plan.arguments to plan.args due to "argument" being a reserved word
  • Rename WasmLegacyBenchmark to AsyncWasmLegacyBenchmark

@camillobruni camillobruni requested a review from danleh January 14, 2026 10:15
@netlify
Copy link

netlify bot commented Jan 14, 2026 •
edited
Loading

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit b7a471e
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/69678a96be63930008db2e1b
😎 Deploy Preview https://deploy-preview-255--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

danleh
danleh approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@danleh danleh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit and questions around async/isAsync.

danleh
danleh approved these changes Jan 14, 2026
View reviewed changes
@camillobruni camillobruni merged commit 1dbb861 into WebKit:main Jan 14, 2026
23 checks passed
@camillobruni camillobruni deleted the 2026-01-13_plan_bag branch January 14, 2026 13:44
kmiller68 added a commit to kmiller68/JetStream that referenced this pull request Jan 17, 2026
@kmiller68
Replace prefetch logic (WebKit#251) is a 2% regression
6fd0571 
A/B testing indicates this change caused a 2% score change in Safari.
This seems surprising since this was intended to be a purely harness
change. Reverting for now to confirm and to investigate the cause.

This also reverts "Add resource loading bar (WebKit#246)" and "Improve
Benchmark constructor and instance variables (WebKit#255)" as they blocked a
clean revert.

For posterity, this is tracked internally as rdar://problem/168103740
@kmiller68 kmiller68 mentioned this pull request Jan 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danleh danleh danleh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camillobruni @danleh