add test script for replacing a multisig member#1177
Closed
lenkan wants to merge 1 commit intoWebOfTrust:v1.2.7from
Closed
add test script for replacing a multisig member#1177lenkan wants to merge 1 commit intoWebOfTrust:v1.2.7from
lenkan wants to merge 1 commit intoWebOfTrust:v1.2.7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test script for replacing a multisig member completely through one rotation.
I wrote this to verify the functionality and also to get feedback if this is how you should do this.
The other test scripts did not test this scenario. They are using hard coded salts and AIDs that is a bit awkward to run since you have to clear the database and restart witnesses between runs. There are some tests on main that follow this pattern that I use here. If you accept, I will add this to 1.3.x and main. I can also modify more of the other tests, to be runnable without having to clear database.
I realize we do not have to have a test script for every possible scenario. So you can decide if you want this in the repo or not.