fix: rename fetchTsgs parameter saider to diger#1259
Merged
SmithSamuelM merged 1 commit intoWebOfTrust:mainfrom Mar 4, 2026
Merged
fix: rename fetchTsgs parameter saider to diger#1259SmithSamuelM merged 1 commit intoWebOfTrust:mainfrom
SmithSamuelM merged 1 commit intoWebOfTrust:mainfrom
Conversation
jaelliot
force-pushed
the
fix/fetchTsgs-saider-to-diger
branch
from
124aee1 to
fee759e
Compare
The saider parameter in fetchTsgs() actually receives a Diger instance (the SAID digest of the reply). Rename to match the actual type. Changed: - eventing.py: fetchTsgs(db, saider, snh) -> fetchTsgs(db, diger, snh) - routing.py: 3 callsites updated (keyword arg saider= -> diger=) - habbing.py: 2 callsites updated (keyword arg saider= -> diger=) - escrowing.py: 1 callsite updated (keyword arg saider= -> diger=) ChangeLog entry added under 2.0.0-dev5. Per Sam's direction on 2026-02-26 dev call.
jaelliot
force-pushed
the
fix/fetchTsgs-saider-to-diger
branch
from
fee759e to
a1c2b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
saiderparameter offetchTsgs()todigerto match the actual type (Diger) being passed. Updates all callers.This is part of the Saider→Diger cleanup series directed by Sam (2026-02-26 dev call). The
fetchTsgsfunction ineventing.pyreceives aDigerinstance but the parameter was misleadingly namedsaider.Changes
Function signature
keri.core.eventing.fetchTsgs(db, saider, snh)→fetchTsgs(db, diger, snh)saider (Saider)→diger (Diger)Callers updated (4 sites)
src/keri/core/routing.py— 3 call sites inRevery(lines 315, 376, 469)src/keri/app/habbing.py— 2 call sites inBaseHab(lines 1824, 1903)src/keri/db/escrowing.py— 1 call site inBroker.processEscrowReply(line 114)ChangeLog
2.0.0-dev5inref/ChangeLog.mdRelated