resolution#1
Closed
bob302 wants to merge 2 commits into
Closed
Conversation
Added support for scaling objects for different resolutions
Author
|
//TODO Фиксануть оцентровку текста, немного подправить константы, чтобы поле было не во весь экран |
- Added a rough implementation of changing the background color
Author
|
Фиксанул оцентровку, и набросал фигни с бгшкой, надо будет подчистить |
Author
|
Oops |
Wedyarit
requested changes
Feb 13, 2024
| let result = ContextBuilder::new("Moon & Sun", "wedyarit") | ||
| .window_mode(conf::WindowMode::default().dimensions(1280.0, 1280.0)) | ||
| .window_mode(conf::WindowMode::default() | ||
| .maximized(true) |
Owner
There was a problem hiding this comment.
I assume there is no need to set the default maximum window size. Window size should be comfortable.
| } | ||
| } | ||
|
|
||
| fn set_target_background_color(&mut self, target_color: Color, duration: f32) { |
Owner
There was a problem hiding this comment.
method set_target_background_color is never used
| use ggez::timer; | ||
| use ggez::{graphics, Context, GameResult, event::EventHandler}; | ||
| use ggez::graphics::{Text, TextFragment, Color as GgezColor}; | ||
| use ggez::graphics::{Color, Drawable, Text, TextFragment}; |
| use std::fmt::Alignment; | ||
|
|
||
| use ggez::mint::Point2; | ||
| use ggez::timer; |
| @@ -1,36 +1,51 @@ | |||
| use std::fmt::Alignment; | |||
|
|
|||
| use ggez::mint::Point2; | |||
Owner
There was a problem hiding this comment.
unused import: ggez::mint::Point2
| @@ -1,36 +1,51 @@ | |||
| use std::fmt::Alignment; | |||
Owner
There was a problem hiding this comment.
unused import: std::fmt::Alignment
Author
|
Тебе не впадлу было unused импорты смотреть? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for scaling objects for different resolutions