feat: add IPv6 support for network utilities and distributed training - #2
Open
narutolhy wants to merge 1 commit into
Open
feat: add IPv6 support for network utilities and distributed training#2narutolhy wants to merge 1 commit into
narutolhy wants to merge 1 commit into
Conversation
- Add is_ipv6_address() and format_addr() helpers for proper IPv6 URL formatting - Extend gethostip() with IPv6 fallback for IPv6-only environments - Use format_addr() across infra (sglang_server, rpc_server, rollout_controller, remote_inf_engine) for proper IPv6 bracket wrapping in host:port strings - Fix NCCL tcp:// init_method to bracket IPv6 addresses in fsdp_engine - Use Gloo cpu_group for object collectives in fsdp_engine to avoid NCCL cross-node hang when IB is unavailable - Add per-worker port_range partitioning to avoid TOCTOU port collision races - Bind SGLang to "::" on IPv6 hosts while registering actual host IP Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_ipv6_address()andformat_addr()helpers for proper IPv6 URL formatting (RFC 2732)gethostip()with IPv6 fallback for IPv6-only environmentsformat_addr()across infra (sglang_server, rpc_server, rollout_controller, remote_inf_engine)tcp://init_method to bracket IPv6 addresses in fsdp_enginecpu_groupfor object collectives in fsdp_engine to avoid cross-node hang when IB is unavailableport_rangepartitioning to avoid TOCTOU port collision races::on IPv6 hosts while registering actual host IPTest plan
🤖 Generated with Claude Code