Wrap console.runcode calls in async coroutines to ensure they are awaited#11
Open
kedvall wants to merge 1 commit intoWetmelon:masterfrom
Open
Wrap console.runcode calls in async coroutines to ensure they are awaited#11kedvall wants to merge 1 commit intoWetmelon:masterfrom
kedvall wants to merge 1 commit intoWetmelon:masterfrom
Conversation
Owner
|
Can you target this to |
Author
|
Oh sure, wasn't sure which branch to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used asyncio to wrap the console.runcode calls. This runs them as coroutines and waits for each to return before continuing.
This PR should fix the RuntimeWarning: coroutine ... was never awaited errors when running the dev version of odrivetool.
Here are some screenshots for context:
Errors:
No errors: