Read input only once#346
Conversation
- Unified entry point to string formatting
|
Hi @jdamanalo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Close #238
Time
time for i in {1..5}; _build/release/bin/erlfmt -w 'otp/lib/*/{src,include}/*.{erl,hrl}'; doneMain
real 0m43.746s
user 1m51.063s
sys 0m39.859s
This
real 0m36.764s
user 1m35.922s
sys 0m34.750s
Potential incompatibility
Changed return of
format_[file, file_range, string_full, string_range]to include the original. Type of formatted string from[unicode:chardata()]tostring().Possible alternative: Introduce new tag
unchanged.Question
Can format_file_range be removed?