Conversation
- Github access token 등록 기능 구현 - 레포지토리 추가 기능 구현 - 레포지토리 목록 조회 기능 구현 - 레포지토리 동기화 기능 구현(Github api 연동) - 커밋 목록 조회 기능 구현(커서 기반 무한스크롤) - 커밋 상세 조회 기능 구현
Contributor
|
ggamnunq
reviewed
Apr 7, 2026
| // @OneToMany(mappedBy = "commit", cascade = CascadeType.ALL, orphanRemoval = true) | ||
| // private final List<CommitConnection> commitConnections = new ArrayList<>(); | ||
|
|
||
| public static Commit create(String hash, String message, String authorName, String authorEmail, |
Contributor
There was a problem hiding this comment.
create 할 때 모든 필드 정보를 파라미터로 넣는거보다
dto같은거 하나로 써서
commit.hash = dto.hash();
commit.message = dto.message();
이런식으로 하는거 어떨까요?? 이렇게 하면
Member
Author
|
넵! 리뷰 해당 내용 수정하고 다시 올리겠습니다 ! |
Contributor
|
고생하셨어요!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 작업 내용
주요 변경사항
org.kohsuke:github-api의존성 추가상세 내용
GithubUtil: GitHub API 연동 유틸리티GitHub 토큰 관리
POST /api/github/tokengithubAccessToken필드 추가레포지토리 목록 조회
GET /api/teams/{teamId}/repositories레포지토리 추가
POST /api/teams/{teamId}/repositories레포지토리 동기화
POST /api/repositories/{repositoryId}/sync커밋 목록 (커서 기반 무한스크롤)
GET /api/repositories/{repositoryId}/commits커밋 상세 조회
GET /api/repositories/{repositoryId}/commits/{commitHash}GitHub access token 암호화 및 API 401 에러 처리
다음엔 기능별로 커밋 나눠서 작성하겠습니다아... 😞
✅ 체크리스트
📋 API 명세서
💬 리뷰 요청사항 (선택)
📚 참고 자료 (선택)