Skip to content

Fix macOS ILLink skip tracking for #2586 #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Widthdom merged 3 commits into from
May 24, 2026
Merged

Fix macOS ILLink skip tracking for #2586 #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cddd89
Fix macOS ILLink skip tracking for #2586
Widthdom May 24, 2026
69e510e
Merge remote-tracking branch 'origin/main' into fix-issue2586
Widthdom May 24, 2026
a13d436
Merge remote-tracking branch 'origin/main' into fix-issue2586
Widthdom May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TESTING_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ The test project mirrors the production areas closely.
- `SymbolExtractorTests.Extract_CSharp_InstallScriptFixture_CompletesWithinPracticalBudget`
is a coarse runaway guard for the real `InstallScriptTests.cs` C# extraction fixture. Its wall-clock budget is intentionally broader than a benchmark so slower or noisy CI hosts do not fail the suite for ordinary variance.
- `IndexCommandRunnerTests.RunBackfillFold_PublishedTrimmedBinary_SerializesSuccessAndErrorJson`
publishes a trimmed RID-specific CLI and runs whichever entry point the SDK emits (`cdidx.dll` through `dotnet` or the native `cdidx`/`cdidx.exe` apphost). It is reported as skipped on macOS arm64 while the current SDK/ILLink path can crash before exercising `cdidx`. Do not assume every SDK/runtime pair writes a `cdidx.dll` into self-contained publish output.
publishes a trimmed RID-specific CLI and runs whichever entry point the SDK emits (`cdidx.dll` through `dotnet` or the native `cdidx`/`cdidx.exe` apphost). It is reported as skipped on macOS arm64 while SDK/ILLink can crash before exercising `cdidx` (#2586). Do not assume every SDK/runtime pair writes a `cdidx.dll` into self-contained publish output.
- `McpServerTests.cs`
MCP JSON-RPC behavior and tool outputs.
- `HttpMcpTransportTests.cs`
Expand Down
16 changes: 16 additions & 0 deletions changelog.d/unreleased/2586.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
category: fixed
issues:
- 2586
affected:
- TESTING_GUIDE.md
- tests/CodeIndex.Tests/IndexCommandRunnerTests.cs
---

## English

- **Documented the macOS arm64 ILLink crash skip under the tracked issue (#2586)** — the trimmed `backfill-fold` publish smoke test now reports the current SDK/ILLink crash guard against the issue that tracks the macOS AccessViolation failure.

## 日本語

- **macOS arm64 の ILLink crash skip を追跡 Issue に紐づけました (#2586)** — trimmed `backfill-fold` publish smoke test の SDK/ILLink crash 回避が、macOS AccessViolation failure を追跡する Issue を示すようになりました。
2 changes: 1 addition & 1 deletion tests/CodeIndex.Tests/IndexCommandRunnerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public sealed class SkipOnMacOsArm64FactAttribute : FactAttribute
public SkipOnMacOsArm64FactAttribute()
{
if (OperatingSystem.IsMacOS() && RuntimeInformation.ProcessArchitecture == Architecture.Arm64)
Skip = "macOS arm64 SDK/ILLink currently crashes before this test can exercise cdidx (#2570).";
Skip = "macOS arm64 SDK/ILLink can crash before this test can exercise cdidx (#2586).";
}
}

Expand Down
Loading