Fix SQL MERGE column references - #2612
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
May 24, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UPDATE SET,INSERT (...),VALUES (...), andONpredicates.column_referenceandjoin_condition_referenceedges so MERGE-driven lineage is visible.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter "FullyQualifiedName~ReferenceExtractorTests"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet build src/CodeIndex/CodeIndex.csproj -p:UseSharedCompilation=falsedotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --commits 8a89bae1cfab976c0fb25b1273205778551254f1 --jsoncodex execadversarial review:No blocking/actionable issues found.Full test note:
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=falsewas also run. It failed outside this change's scope: Rust associated type defaults are already tracked by Rust associated type defaults are not emitted for trait symbols #2603, and a macOS arm64 ILLinkAccessViolationExceptionduring trimmed publish was filed as macOS arm64 trimmed publish test can crash in ILLink #2606.Documentation And Changelog
changelog.d/unreleased/2100.fixed.md.Follow-Up Candidates
Fixes #2100