Handle file deletion races during indexing - #2634
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~FileIndexerTests"passed before the latest origin/main merge.dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~FileIndexerTests.ScanFilesDetailed_FileDeletedAfterEnumeration_RecordsWarning"passed after the latest origin/main merge.dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsepassed after the latest origin/main merge.dotnet run --project tools/CodeIndex.Changelog -- checkpassed.dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=falsewas attempted, but a trimmed publish test failed due an unrelated file lock onsrc/CodeIndex/obj/Debug/net8.0/osx-arm64/linked/cdidx.pdbwhile publishing.Review
origin/main..HEAD: No blocking/actionable issues found.codex execadversarial review was attempted but could not run because the local Codex CLI reported a usage limit.Changelog
changelog.d/unreleased/2044.fixed.mdFixes #2044