Skip to content

Mark impact result row kinds - #2644

Merged
Widthdom merged 3 commits into
mainfrom
fix-issue1779
May 24, 2026
Merged

Mark impact result row kinds#2644
Widthdom merged 3 commits into
mainfrom
fix-issue1779

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Add explicit result_kind markers to impact output: graph for graph caller rows and file_heuristic for heuristic file dependency hints.
  • Propagate the marker through CLI/MCP JSON DTOs, golden output, documentation, and targeted regression tests.

Validation

  • dotnet build CodeIndex.sln
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter "FullyQualifiedName~DbReaderTests.AnalyzeImpact_NotTruncated_LeavesTruncatedReasonNull|FullyQualifiedName~DbReaderTests.AnalyzeImpact_ClassSymbolReturnsHeuristicFileDependencyHints|FullyQualifiedName~QueryCommandRunnerTests.RunImpact_UnicodeTypeEvidenceStillReturnsHeuristicHints|FullyQualifiedName~JsonOutputSnapshotTests"
  • dotnet test CodeIndex.sln --no-build (net8.0 full suite passed; net9.0 full suite was rerun via dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net9.0 --no-build and passed)
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • Codex adversarial review: No blocking/actionable issues found.

Documentation and Changelog

  • Updated DEVELOPER_GUIDE.md.
  • Added changelog fragment changelog.d/unreleased/1779.fixed.md.

Follow-up

Fixes #1779

@Widthdom
Widthdom merged commit ad3f1e2 into main May 24, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue1779 branch May 24, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impact_analysis depth fallback conflates graph and heuristic results in one list

1 participant