Harden release archives and installer verification - #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MANIFEST.sha256inside release archives and make the installer verify every extracted file, including legacy fallback for pre-manifest releases.integrity_okand require that marker before skipping same-version installs.Validation
bash -n install.shdotnet run --project tools/CodeIndex.Changelog -- checkgit diff --check origin/main..HEADbash install.sh --self-test-local-mirror v9.9.9dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter InstallScriptTestsNo blocking/actionable issues found.Documentation / Changelog
.codex/workflows/release-changelog.mdwith manifest and stable-archive release expectations.changelog.d/unreleased/2012.fixed.mdchangelog.d/unreleased/2040.fixed.mdchangelog.d/unreleased/2041.fixed.mdIssue Scope
Fixes #2012
Fixes #2040
Fixes #2041