Fail closed on invalid CLI options - #2696
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--depth 999999999.--as literals.cdidx indexunknown options fatal usage errors with did-you-mean hints instead of warning and continuing.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~QueryCommandRunnerTests|FullyQualifiedName~IndexCommandRunnerTests" --no-restoredotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunImpact_OutOfRangeDepthUpperBound_ReturnsUsageError_Issue1700|FullyQualifiedName~RunSearch_UnknownFlagAfterQuery_ReturnsUsageError|FullyQualifiedName~Run_UnknownIndexOption_ReturnsUsageError|FullyQualifiedName~ParseArgs_EndOfOptionsAllowsDashPrefixed|FullyQualifiedName~RunSearch_EndOfOptionsAcceptsOptionLookingLiteral|FullyQualifiedName~ParseArgs_UnknownIndexOption" --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkNo blocking/actionable issues found.Documentation / Changelog
changelog.d/unreleased/1700.fixed.mdchangelog.d/unreleased/1705-1801.fixed.mdchangelog.d/unreleased/1803.fixed.mdIssues
Fixes #1700
Fixes #1705
Fixes #1801
Fixes #1803
Follow-up Candidates
None.