Stabilize symbol ordering and reference dedupe - #2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_columnand symbol id tie-breaks for definition symbol searches.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter "BuildReferenceDedupeKey|AddTypeReferenceSegment_DedupesWithinFileAndLanguageOnly"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter "SearchSymbols_BreaksSameLineTiesByStartColumn|GetSymbolHotspots_BreaksEqualCountsByPathLineNameKind|GetSymbolHotspots_RanksRealCallsAboveManyLowerWeightSubscribeEdges"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=falsewas attempted; it failed because test-localgit commitcommands inherited the local SSH signing key and could not unlock/Users/widthdom/.ssh/id_ed25519_signing.GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=falsewas attempted; MSBuild failed in this sandbox withSystem.Net.Sockets.SocketException (13): Permission deniedwhile starting out-of-proc nodes.Documentation and changelog
changelog.d/unreleased/2015.fixed.mdchangelog.d/unreleased/1934.fixed.mdchangelog.d/unreleased/1974.fixed.mdFollow-up candidates
E013_INDEX_EXTRACTION_STALLEDfull-scan failure observed while refreshing the local index.Fixes #2015
Fixes #1934
Fixes #1974