Tighten MCP tool contracts - #2714
Merged
Merged
Conversation
Widthdom
force-pushed
the
fix-issue1778-1723-1696
branch
from
May 31, 2026 04:03
adb158e to
f81a512
Compare
Widthdom
force-pushed
the
fix-issue1778-1723-1696
branch
from
May 31, 2026 04:22
f81a512 to
3bb9cb9
Compare
Widthdom
marked this pull request as ready for review
May 31, 2026 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalProperties: falseand reject unknowntools/callarguments, including nestedbatch_queryslots.x-stabilitymarkers and mark experimental tools intools/list.Validation
dotnet builddotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpServerTests.ToolsList_EveryInputSchemaRejectsAdditionalPropertiesAndPublishesStability|FullyQualifiedName~McpServerTests.ToolsCall_UnknownArgument_ReturnsInvalidParams|FullyQualifiedName~McpServerTests.ToolsList_CallersCalleesAnalyzeSymbolDescriptions_PinSnakeCaseMixedKindFields|FullyQualifiedName~McpServerTests.ToolsCall_ExactAliases_RejectsCombinedFlags|FullyQualifiedName~McpServerTests.ToolsCall_Search_RejectsExactNameAlias|FullyQualifiedName~McpServerTests.ToolsCall_Symbols_RejectsExactSubstringAlias|FullyQualifiedName~McpServerTests.ToolsCall_Search_RejectsFalseExactNameAlias|FullyQualifiedName~McpServerTests.ToolsCall_Symbols_RejectsFalseExactSubstringAlias|FullyQualifiedName~McpServerTests.ToolsCall_ImpactAnalysis_CountOnly_OmitsCallerRows"Docs / Changelog
README.mdandDEVELOPER_GUIDE.md.changelog.d/unreleased/1696.added.mdchangelog.d/unreleased/1723.changed.mdchangelog.d/unreleased/1778.fixed.mdReview
codex execadversarial review was attempted but blocked by the Codex usage limit.origin/main..HEADfound and fixed the missingbatch_queryunknown-argument validation path.Notes
McpServerTestswas not used as final validation because local Git commit signing prompts for/Users/widthdom/.ssh/id_ed25519_signingin temp-repo tests. Targeted MCP tests above passed on bothnet8.0andnet9.0.Fixes #1778
Fixes #1723
Fixes #1696