Fix ignore rule parsing and loading edge cases - #2715
Merged
Conversation
Widthdom
marked this pull request as ready for review
May 31, 2026 04:58
…53-1657-1658 # Conflicts: # tests/CodeIndex.Tests/IndexCommandRunnerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore/.cdidxignoreleading-whitespace parsing so comments and patterns match Git-style behavior..cdidxignorediscovery, syntax, and precedence in the user guide and CLI help.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~FileIndexerTests" -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falseDocumentation and changelog
USER_GUIDE.mdDEVELOPER_GUIDE.mdchangelog.d/unreleased/1620.fixed.mdchangelog.d/unreleased/1621.docs.mdchangelog.d/unreleased/1653.fixed.mdchangelog.d/unreleased/1657.fixed.mdchangelog.d/unreleased/1658.fixed.mdReview
codex exec review --base origin/main.Follow-up candidates
E013_INDEX_EXTRACTION_STALLEDwhile extractingsrc/CodeIndex/Indexer/References/Languages/SqlReferenceExtractor.cs; this appears to duplicate existing issue index: full scan stalls extracting SqlReferenceExtractor.cs symbols #2710.Fixes #1620
Fixes #1621
Fixes #1653
Fixes #1657
Fixes #1658