Stabilize command-dispatch exit codes - #2722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnhandledExceptionexit code99for unexpected command-dispatch failures.BUSY,LOCKED, andREADONLYfailures as transient database exit code6, while keeping permanent SQLite failures on database exit code3.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ProgramRunnerTests.Run_UnhandledException_ReturnsSanitizedSingleLineError|FullyQualifiedName~ProgramRunnerTests.Run_ForcedGlobalToolLogging_WritesUnhandledExceptionChain|FullyQualifiedName~ProgramCliTests.Run_Unhandled" -p:UseSharedCompilation=falsedotnet build CodeIndex.sln --no-restoreNo blocking/actionable issues found.Documentation and Changelog
USER_GUIDE.mdexit-code tables in English and Japanese.changelog.d/unreleased/1660.fixed.md.changelog.d/unreleased/1663.fixed.md.Notes
dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonstill reports the local index as stale/degraded because the existing workspace index predates several unrelated main-branch changes. A scoped refresh of the files changed by this PR succeeded.Fixes #1660
Fixes #1663