Fix platform path separator handling - #2726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~FileIndexerTests.NormalizeIgnorePath_PosixPreservesLiteralBackslash|FullyQualifiedName~IndexCommandRunnerTests.IsOutsideProjectRoot|FullyQualifiedName~ProgramRunnerTests.IsProjectPathArg" -p:UseSharedCompilation=falsedotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --commits a57ed0cce0f9fd2f855eca6842ea0ba1539486eb 88652f15e2447ceb6057a2f8f625a6f8f292a58c 2aa93b66fdc26ce2b2e639691343779419ba3bc8 --jsonNo blocking/actionable issues found.Documentation and Changelog
changelog.d/unreleased/1715.fixed.md.changelog.d/unreleased/1717.fixed.md.changelog.d/unreleased/1725.fixed.md.Follow-up Candidates
Fixes #1715
Fixes #1717
Fixes #1725