Fix MCP reader cleanup and error reporting - #2742
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbReaderinstances deterministically, including the index-project SQL graph signal reader.failed_count, a cappedfailureslist, and global log context.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter "FullyQualifiedName~DbDebugTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter "FullyQualifiedName~McpServerTests"was attempted; 424 tests passed per target framework and 7 existing Git-metadata tests failed because local Git commit signing requested/Users/widthdom/.ssh/id_ed25519_signingpassphrase in temp repositories.Documentation and Changelog
changelog.d/unreleased/1714.fixed.mdchangelog.d/unreleased/1716.fixed.mdchangelog.d/unreleased/1720.fixed.mdchangelog.d/unreleased/2010.fixed.mdReview
Adversarial review result: No blocking/actionable issues found.
Follow-up Candidates
Fixes #1714
Fixes #1716
Fixes #1720
Fixes #2010