Add CI coverage, formatting policy, and dev task wrappers - #2771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.editorconfig, enforcedotnet format, and treat compiler warnings as errors with an explicit trim-warning allowlist.Makefileanddev.sh, document them, and verify the wrapper path in CI.Validation
dotnet run --project tools/CodeIndex.Changelog -- checkdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restoremake lintmake buildmake mcp-smokedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -f net8.0 --filter "FullyQualifiedName~RunPublishedTrimmedCli_SerializesQueryJsonAndErrorJson" --settings tests/CodeIndex.Tests/CodeIndex.Tests.runsettings --blame-crash --blame-hang --blame-hang-timeout 5mdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNote: a full
make testrun initially failed only onRunPublishedTrimmedCli_SerializesQueryJsonAndErrorJsonbecause warning-as-error made existing trim warnings fatal; after adding the explicit allowlist andILLinkTreatWarningsAsErrors=false, the failing test passed.Documentation and Changelog
CONTRIBUTING.mdandDEVELOPER_GUIDE.md.changelog.d/unreleased/1608.fixed.mdchangelog.d/unreleased/1609.internal.mdchangelog.d/unreleased/1611.internal.mdReview
codex execreview attempt was blocked by usage limits, so the same workflow was applied manually in this Codex session.Fixes #1608
Fixes #1609
Fixes #1611