Skip to content

Fix net9 console capture disposal - #2790

Merged
Widthdom merged 3 commits into
mainfrom
codex/fix-issue2775
May 31, 2026
Merged

Fix net9 console capture disposal#2790
Widthdom merged 3 commits into
mainfrom
codex/fix-issue2775

Conversation

@Widthdom

@Widthdom Widthdom commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stop ConsoleCapture from disposing captured stdout/stderr writers after restoring global console streams.
  • Put ConsoleCaptureTests and ChangelogToolTests in the existing non-parallel test collection.
  • Add changelog fragment changelog.d/unreleased/2775.fixed.md.

Fixes #2775

Out of scope

Validation

  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -f net9.0 -p:WarningsNotAsErrors=IL2026%3BIL2067%3BIL2072%3BIL2075%3BIL3050 --filter "FullyQualifiedNameConsoleCaptureTests|FullyQualifiedNameChangelogToolTests|FullyQualifiedNameMcpServerTests|FullyQualifiedNameLegacySchemaMigrationTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -f net9.0 -p:WarningsNotAsErrors=IL2026%3BIL2067%3BIL2072%3BIL2075%3BIL3050 (failed only in RunPublishedTrimmedCli_SerializesQueryJsonAndErrorJson due existing dotnet test fails with Native AOT IL3050 analyzer errors #2786)

Review

  • Adversarial review: No blocking/actionable issues found.

Follow-up candidates

  • None.

@Widthdom
Widthdom merged commit 4f25d2f into main May 31, 2026
10 checks passed
@Widthdom
Widthdom deleted the codex/fix-issue2775 branch June 3, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net9 full test run can fail with closed TextWriter during parallel console writes

1 participant