Skip to content

Deprecate find file_count JSON alias - #2794

Merged
Widthdom merged 6 commits into
mainfrom
fix-issue1423
May 31, 2026
Merged

Deprecate find file_count JSON alias#2794
Widthdom merged 6 commits into
mainfrom
fix-issue1423

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary:

  • Document files as the canonical cdidx find --count --json matched-file count.
  • Keep file_count as a deprecated compatibility alias with matching value and next-major removal timing.
  • Add a focused regression assertion and changelog fragment.

Validation:

  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~QueryCommandRunnerTests.RunFind_CountOnlyJsonUsesFilesAsCanonicalCountAndKeepsDeprecatedAlias_Issue1423 -p:UseSharedCompilation=false -p:EnableAotAnalyzer=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • adversarial review: no blocking findings

Fixes #1423

@Widthdom
Widthdom merged commit c60dfb2 into main May 31, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue1423 branch May 31, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QueryFindCountJsonResult exposes both 'files' and 'file_count' for the same value

1 participant