Fix excerpt aliases, guard argument handling, and progress opt-out - #2802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--start-line/--end-linealiases forquery --excerpt.--no-progress,CDIDX_DISABLE_PROGRESS=1, andPREFERS_REDUCED_MOTION.Validation
python3 -m unittest discover -s .agent_harness/tests -p 'test_command_guard_core.py'dotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --filter "RunExcerpt_AcceptsMcpStyleStartAndEndLineAliases|ShouldUseProgressAnimation_EnvOptOutDisablesAnimation|ShouldUseProgressAnimation_ReducedMotionDisablesAnimation|TryConsumeNoProgressFlag_RemovesGlobalFlagAndDisablesAnimation|FormatProgressLine_ProgressAnimationDisabled_UsesStaticPrefix|PrintCompletions_ReportFlagSetsMatchAcrossShells" -p:UseSharedCompilation=false -p:EnableAotAnalyzer=false -p:EnableTrimAnalyzer=falsedotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false -p:EnableAotAnalyzer=false -p:EnableTrimAnalyzer=falseNo blocking/actionable issues found.Full Release build/test without disabling AOT/trim analyzers currently fails on latest
origin/mainwith existing IL3050/IL2026 analyzer diagnostics unrelated to this branch.Changelog
changelog.d/unreleased/1429.fixed.mdchangelog.d/unreleased/1432.fixed.mdchangelog.d/unreleased/1630.added.mdNotes
AGENT.md,CLAUDE.md, andAGENT_GUIDE.mdwere not modified.Fixes #1429
Fixes #1432
Fixes #1630