Cap per-file symbol output during indexing - #2803
Merged
Merged
Conversation
# Conflicts: # src/CodeIndex/Cli/IndexCommandRunner.Update.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdidx index --max-symbols-per-file Nto cap pathological per-file symbol output.symbol_count_exceededfile issues and skip content/chunk/symbol/reference rows for files above the cap.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~IndexCommandRunnerTests.Run_FileAboveMaxSymbolsPerFile_PersistsSymbolCountExceededIssueOnly /p:WarningsNotAsErrors=IL2026%3BIL2067%3BIL2072%3BIL2075%3BIL3050dotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --rebuild --yes --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo blocking/actionable issues found.Full
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj /p:WarningsNotAsErrors=IL2026%3BIL2067%3BIL2072%3BIL2075%3BIL3050currently fails in the unrelated trimmed publish test path because test-internaldotnet publishstill treats IL3050 as an error. Tracked separately in #2801.Documentation And Changelog
README.mdfor the new indexing cap flag and stall remediation hint.changelog.d/unreleased/1604.fixed.mdchangelog.d/unreleased/2744.fixed.mdFollow-Ups
Fixes #1604
Fixes #2744