Skip to content

Bound and sanitize GitHub suggestion submission - #2919

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue2855-2888
Jun 2, 2026
Merged

Bound and sanitize GitHub suggestion submission#2919
Widthdom merged 4 commits into
mainfrom
fix-issue2855-2888

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bound outbound GitHub suggestion code scrubbing with a capped linear scanner for fenced and inline code.
  • Read only a small GitHub API error body excerpt for failed issue creation and rate-limit diagnostics.
  • Redact sensitive JSON-like error fields before stderr output and persisted retry details.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~GitHubIssueReporterTests -p:UseSharedCompilation=false
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Documentation / Changelog

  • Added changelog.d/unreleased/2855.security.md.
  • Added changelog.d/unreleased/2888.security.md.
  • No AGENTS.md, CLAUDE.md, or AGENT_GUIDE.md changes.

Review

  • Codex adversarial review: No blocking/actionable issues found.

Follow-up candidates

None.

Fixes #2855
Fixes #2888

@Widthdom
Widthdom marked this pull request as ready for review June 2, 2026 14:14
@Widthdom
Widthdom force-pushed the fix-issue2855-2888 branch from cf755b2 to c2850c6 Compare June 2, 2026 15:45
@Widthdom
Widthdom merged commit e1614d8 into main Jun 2, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2855-2888 branch June 2, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub issue reporter code scrub should bound input and regex runtime Bound and sanitize GitHub API response bodies in suggestion submission

1 participant