Harden cdidx import archive validation - #2926
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.jsonduringcdidx import, includingformat_version,user_version, anddatabase_sha256checks before installing the database.codeindex.dbarchive extraction by compressed/uncompressed metadata and by stream-copy byte count.DEVELOPER_GUIDE.md.Validation
dotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --filter FullyQualifiedName~ProgramCliTests -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --filter FullyQualifiedName~ExportImportCommandRunnerTests -p:UseSharedCompilation=falsedotnet format CodeIndex.sln --verify-no-changesdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --framework net8.0 --filter FullyQualifiedName~ExportImportCommandRunnerTests -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --framework net8.0 --filter FullyQualifiedName~ProgramCliTests -p:UseSharedCompilation=falsedotnet build tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false -m:1 -nr:falseProgramCliTests.ImportArchive_RejectsDatabaseHashMismatch; local VSTest could not start because this environment deniesTcpListenersocket bind (SocketException (13): Permission denied).Documentation and changelog
DEVELOPER_GUIDE.mdchangelog.d/unreleased/2834.security.mdchangelog.d/unreleased/2835.security.mdReview
codex exec review --base origin/main, but the subprocess did not complete because its internal tool calls timed out; the session was stopped after bounded waiting.origin/main..HEADfound no blocking/actionable issues after adding the missing documentation updates.Follow-up candidates
hotspot_family_readyrecommended-action mismatch during index refresh.Fixes #2834
Fixes #2835