Skip to content

Split oversized test files by feature area - #2940

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue2817
Jun 2, 2026
Merged

Split oversized test files by feature area#2940
Widthdom merged 1 commit into
mainfrom
fix-issue2817

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Split the oversized query command, reference extractor, and symbol extractor test classes into feature-focused partial class files.
  • Kept the original shared helpers in the root test files and updated TESTING_GUIDE.md for the new layout.
  • Added a changelog fragment for the internal test-layout change.
  • Sanitized child CLI subprocess environments in query command tests so ambient cdidx defaults from parallel tests do not leak into subprocess assertions.

Validation

  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --filter "FullyQualifiedName~QueryCommandRunnerTests|FullyQualifiedName~ReferenceExtractorTests|FullyQualifiedName~SymbolExtractorTests" -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --no-restore --environment CDIDX_DEFAULT_LIMIT=6 --filter FullyQualifiedName~RunReferences_ExactJson_SqlNonAsciiBareIdentifiersStayWhole
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Codex adversarial review completed; no branch-specific actionable findings after the subprocess environment fix.

Notes

Fixes #2817

@Widthdom
Widthdom marked this pull request as ready for review June 2, 2026 14:07
@Widthdom
Widthdom force-pushed the fix-issue2817 branch 7 times, most recently from a6087d4 to ef76636 Compare June 2, 2026 20:15
Rebase the split test layout onto the latest main and move upstream status/validate additions into focused partial test files.
@Widthdom
Widthdom merged commit 55c311e into main Jun 2, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2817 branch June 2, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split oversized test files by feature area

1 participant