Skip to content

Fix C# graph and LSP common-token conflation - #2952

Merged
Widthdom merged 7 commits into
mainfrom
fix-issue2818-2831
Jun 3, 2026
Merged

Fix C# graph and LSP common-token conflation#2952
Widthdom merged 7 commits into
mainfrom
fix-issue2818-2831

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Prevent C# argument-list member calls from being indexed as standalone function definitions and keep bare exact C# caller graph queries from counting receiver-qualified calls.
  • Scope LSP definition and references to the resolved indexed document before workspace fallback, including common tokens with no indexed definition target.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Debug --filter "FullyQualifiedName~SymbolExtractorTests.Extract_CsharpExpressionArgumentMemberCalls_AreNotDefinitions|FullyQualifiedName~DbReaderTests.GraphQueries_CsharpBareMemberCallersSkipReceiverQualifiedCalls|FullyQualifiedName~LspServerTests.HandleMessage_Definition_PrefersCurrentIndexedDocumentForCommonToken|FullyQualifiedName~LspServerTests.HandleMessage_References_PrefersCurrentIndexedDocumentForCommonToken|FullyQualifiedName~LspServerTests.HandleMessage_References_PrefersCurrentIndexedDocumentWhenCommonTokenHasNoDefinitions"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --changed-between origin/main HEAD --json

Documentation And Changelog

  • Added changelog.d/unreleased/2818.fixed.md.
  • Added changelog.d/unreleased/2831.fixed.md.

Review

No blocking/actionable issues found.

Follow-ups

None.

Fixes #2818
Fixes #2831

@Widthdom
Widthdom merged commit b10df50 into main Jun 3, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2818-2831 branch June 3, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP definition and references conflate common tokens across the workspace Graph queries conflate common method names across types

1 participant