Skip to content

Bound subprocess execution for git helpers and upgrade installer - #2962

Merged
Widthdom merged 5 commits into
mainfrom
fix-issue2832-2827
Jun 2, 2026
Merged

Bound subprocess execution for git helpers and upgrade installer#2962
Widthdom merged 5 commits into
mainfrom
fix-issue2832-2827

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bound GitHelper subprocess runtime and captured stdout/stderr, returning explicit diagnostics when timeout or capture limits are hit.
  • Launch cdidx upgrade installer with ProcessStartInfo.ArgumentList and terminate stalled installer runs with a clear error.
  • Added regression coverage for git timeout/output caps and upgrade installer argument/timeout behavior.

Validation

  • dotnet build -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~GitHelperTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ProgramRunnerTests -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • Adversarial review: no blocking/actionable issues remain after fixes. External codex exec review --base origin/main --ephemeral was attempted twice but blocked by Codex usage/model availability limits in this environment.

Documentation / Changelog

  • Added changelog.d/unreleased/2832.fixed.md.
  • Added changelog.d/unreleased/2827.fixed.md.
  • No direct CHANGELOG.md update; ordinary issue-fix fragments were used.

Follow-up Candidates

  • None.

Fixes #2832
Fixes #2827

@Widthdom
Widthdom marked this pull request as ready for review June 2, 2026 19:03
@Widthdom
Widthdom merged commit 67b774d into main Jun 2, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2832-2827 branch June 2, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git helper subprocesses need timeouts and captured-output caps cdidx upgrade should use ArgumentList and bound installer runtime

1 participant