Skip to content

Classify validate replacement characters - #2965

Merged
Widthdom merged 1 commit into
mainfrom
codex/issue-2814
Jun 2, 2026
Merged

Classify validate replacement characters#2965
Widthdom merged 1 commit into
mainfrom
codex/issue-2814

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add origin/severity metadata to validate replacement_char diagnostics.
  • Classify intentional U+FFFD literals as source_literal/info and decoder replacements as decode_replacement/warning.
  • Preserve new file_issues metadata through DB reads, writes, migrations, and unchanged-file reuse.

Validation

  • dotnet build
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedNameValidateContent_|FullyQualifiedNameRunValidate_ReplacementCharJson_IncludesOriginAndSeverity|FullyQualifiedName~GetUnchangedFileId_ReturnsNullWhen"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • cdidx status --check --json
  • cdidx validate --json

Notes

Fixes #2814

@Widthdom
Widthdom marked this pull request as ready for review June 2, 2026 20:13
@Widthdom
Widthdom merged commit 7224048 into main Jun 2, 2026
11 checks passed
@Widthdom
Widthdom deleted the codex/issue-2814 branch June 2, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow validate to distinguish intentional U+FFFD literals

1 participant