Limit MCP response serialization - #2970
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToJsonStringwith a bounded UTF-8 JSON writer that stops when the configured byte cap is crossed.batch_queryresponse estimates and mark whetherresponse_too_large.error.data.actual_bytesis exact.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~McpServerTests -p:UseSharedCompilation=false -m:1 -nr:falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonAttempted
dotnet test CodeIndex.sln -p:UseSharedCompilation=false; sandboxed MSBuild first failed with named-pipe bind permission errors, then the escalated full run surfaced an unrelated transient SQL extractor test failure that passed when rerun directly and was stopped after becoming long-running. Targeted MCP coverage passed on net8.0 and net9.0 after the final rebase-equivalent cleanup.Documentation and Changelog
changelog.d/unreleased/2860.security.md.Review
.codex/workflows/adversarial-review.md: no blocking/actionable issues found.Follow-up Candidates
Fixes #2860