Skip to content

Redact secret assignments in logs and suggestions - #3275

Merged
Widthdom merged 8 commits into
mainfrom
fix-issue3005-3006-3070-3071
Jun 5, 2026
Merged

Redact secret assignments in logs and suggestions#3275
Widthdom merged 8 commits into
mainfrom
fix-issue3005-3006-3070-3071

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Redact underscore-separated API/access key options in global tool logs, including assignment and split-value forms.
  • Bound global log and suggestion redaction work with input caps, timeout-bounded regexes, and truncation markers.
  • Extend suggestion redaction to common token/API/access key assignments, sampled MCP metadata, CLI suggestion output, and issue-draft titles.
  • Return the stored redacted suggestion hash from suggest_improvement and preserve sampled metadata/evidence safely when redaction clones records.

Changelog

  • Added security fragments:
    • changelog.d/unreleased/3005.security.md
    • changelog.d/unreleased/3006.security.md
    • changelog.d/unreleased/3070.security.md
    • changelog.d/unreleased/3071.security.md

Validation

  • dotnet build CodeIndex.sln -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter 'FullyQualifiedName~GlobalToolLogTests|FullyQualifiedName~SuggestionStoreTests|FullyQualifiedName~McpServerTests|FullyQualifiedName~ProgramCliTests.Suggestions_ExportIssueDrafts' -p:UseSharedCompilation=false
  • Codex adversarial review: No blocking/actionable issues found.

Fixes #3005
Fixes #3006
Fixes #3070
Fixes #3071

@Widthdom
Widthdom marked this pull request as ready for review June 5, 2026 00:51
@Widthdom
Widthdom merged commit 174e463 into main Jun 5, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3005-3006-3070-3071 branch June 5, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant