Skip to content

Fix top-level log flag schema coverage - #3283

Merged
Widthdom merged 5 commits into
mainfrom
fix-issue3226
Jun 5, 2026
Merged

Fix top-level log flag schema coverage#3283
Widthdom merged 5 commits into
mainfrom
fix-issue3226

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Added top-level scope to CliFlagSchema and derive ProgramRunner global parser flag sets from it.
  • Surface --log-format, --log-retain-count, and --log-max-size-mb in help and bash/zsh/fish/PowerShell completions.
  • Added schema/completion tests that guard parser drift for the top-level log flags.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --configuration Release --framework net9.0 --filter "FullyQualifiedName=CodeIndex.Tests.McpAuditLogTests.ToolsCall_TruncatesAuditRequestId_Issue3237"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --configuration Release --framework net9.0 --filter "FullyQualifiedName~McpAuditLogTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~CliFlagSchemaTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ConsoleUiTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ProgramRunnerTests"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll . --json
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • dotnet test passed before merging latest origin/main; after conflict resolution, a full rerun was stopped after 19m+ with no failure output, while the targeted tests above passed.
  • Adversarial review: No blocking/actionable issues found.

Docs and Changelog

  • Updated CLI help output for top-level log flags.
  • Added changelog.d/unreleased/3226.fixed.md.

Related

Fixes #3226

@Widthdom
Widthdom marked this pull request as ready for review June 5, 2026 02:59
@Widthdom
Widthdom merged commit d616d43 into main Jun 5, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3226 branch June 5, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top-level global log flags should be covered by a tested CLI schema or completion contract

1 participant