Cap report schema summary work - #3284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdidx report --dbschema table enumeration at 64 entries and omit additional tables fromschema.txt.Validation
dotnet format CodeIndex.sln --verify-no-changesdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter FullyQualifiedName~ReportCommandRunnerTestsdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --filter FullyQualifiedName~ExtractorPluginRegistryTests.LoadPluginAssemblies_RetainsCapDiagnosticWhenCandidatesAlsoFailToLoaddotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonFull
dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=falsewas attempted, but I stopped it after a long no-output run. It had reported one unrelatedExtractorPluginRegistryTestsregex-timeout failure first; that specific test passed on isolated rerun for both target frameworks.Documentation / Changelog
USER_GUIDE.mdreport bundle text in English and Japanese.changelog.d/unreleased/3146.security.md.Review
Adversarial review found one documentation wording issue (
no user contentwas too strong because schema summaries still include table names). That was fixed; no blocking/actionable issues remained after re-review.Follow-up Candidates
Fixes #3146