Skip to content

Avoid pattern config split allocations - #3305

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue3052
Jun 5, 2026
Merged

Avoid pattern config split allocations#3305
Widthdom merged 4 commits into
mainfrom
fix-issue3052

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Parse bounded pattern config text line-by-line without materializing a whole-file newline split array.
  • Keep scalar parsing behavior span-based and allocate only parsed scalar values.
  • Add a many-line configured pattern regression test.
  • Merge the latest origin/main into fix-issue3052 to resolve the PR conflict and keep the PR diff current.

Validation

  • dotnet build
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll . --json
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SymbolExtractorTests.Extract_ConfiguredPatternYaml|FullyQualifiedName~McpAuditLogTests.ToolsCall_TruncatesAuditRequestId_Issue3237"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet test

Documentation / Changelog

  • Added changelog.d/unreleased/3052.security.md.
  • No AGENTS.md, CLAUDE.md, or AGENT_GUIDE.md updates were made.

Review

  • Adversarial review: No blocking/actionable issues found in the final origin/main-based diff.

Fixes #3052

@Widthdom
Widthdom marked this pull request as ready for review June 5, 2026 09:21
# Conflicts:
#	src/CodeIndex/Mcp/AuditLogSink.cs
@Widthdom
Widthdom merged commit f7c94f1 into main Jun 5, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3052 branch June 5, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pattern config loading should avoid whole-file newline Split allocations

1 participant