Skip to content

[codex] Fix workspace manifest and use validation - #3321

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue3216-3217-3165-3041
Jun 6, 2026
Merged

[codex] Fix workspace manifest and use validation#3321
Widthdom merged 4 commits into
mainfrom
fix-issue3216-3217-3165-3041

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bound workspace manifest member path strings and default_db_name, while keeping the existing member-count cap.
  • Reject unknown workspace index_strategy values instead of silently falling back to per-member behavior.
  • Make workspace use reject missing members and ambiguous same-basename members before writing active workspace state.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --filter "FullyQualifiedName~WorkspaceCommandRunnerTests" -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet build CodeIndex.sln -p:UseSharedCompilation=false after each issue commit
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Codex adversarial review: No blocking/actionable issues found.

Documentation / Changelog

  • Updated DEVELOPER_GUIDE.md workspace manifest and workspace use contracts.
  • Added changelog fragments:
    • changelog.d/unreleased/3216.fixed.md
    • changelog.d/unreleased/3041.fixed.md
    • changelog.d/unreleased/3217.fixed.md
    • changelog.d/unreleased/3165.fixed.md

Follow-up candidates

None.

Fixes #3216
Fixes #3217
Fixes #3165
Fixes #3041

@Widthdom
Widthdom marked this pull request as ready for review June 6, 2026 06:11
@Widthdom
Widthdom merged commit 8427d74 into main Jun 6, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3216-3217-3165-3041 branch June 6, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant