Fix MCP cursor and guard filter bounds - #3326
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources/listcursors, use checked page-limit arithmetic, and avoid emittingnextCursorvalues outside the accepted range.Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpServerTests.ResourcesList"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ToolsCall_Search_InvalidCursorDomain"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ToolsCall_Search_GuardFiltersFailFastWhenCombinedArraysExceedLimit"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpServerTests"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonorigin/main..HEAD; initial finding fixed, second review reported no blocking/actionable issues.Documentation / Changelog
changelog.d/unreleased/3073.fixed.mdchangelog.d/unreleased/3112.fixed.mdchangelog.d/unreleased/3193.fixed.mdFollow-up Candidates
None.
Fixes #3112
Fixes #3193
Fixes #3073