Fix cleanup probes and restore temp handling - #3336
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes seven cleanup/probe edge cases where temporary probes or staging directories could either leak, mask the original command result, or collide under same-millisecond naming.
Changes
Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SuggestImprovement_WriteProbeCleanupFailureWarnsWithoutFailing_Issue3023|FullyQualifiedName~CanWriteDirectory_ProbeCleanupFailureWarnsWithoutFailing_Issue3024|FullyQualifiedName~ResolveIgnoreCase_NonRepoProbeAvoidsRootProbeArtifacts_Issue3174|FullyQualifiedName~Constructor_CaseProbeAvoidsRootProbeArtifacts_Issue3174|FullyQualifiedName~Constructor_CaseProbePreservesExistingCdidxDirectory_Issue3174|FullyQualifiedName~RunImport_TemporaryDatabaseCleanupFailureWarnsAndPreservesImportError_Issue3032|FullyQualifiedName~RunExportArchive_TemporaryDatabaseCleanupFailureWarnsWithoutFailing_Issue3032|FullyQualifiedName~Run_CheckpointTempCleanupFailurePreservesOriginalFailure_Issue3029|FullyQualifiedName~Run_RestoreTemporaryNamesIncludeCollisionResistantSuffix_Issue3031|FullyQualifiedName~Run_RestoreTempCleanupFailureWarnsWithoutFailing_Issue3030"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet builddotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsoncodex exec --sandbox read-only --ephemeral review --base origin/mainFixes #3023
Fixes #3024
Fixes #3174
Fixes #3032
Fixes #3030
Fixes #3029
Fixes #3031