Skip to content

Fix changed-between dry-run range handling - #3337

Merged
Widthdom merged 3 commits into
mainfrom
fix-issue2987-3046
Jun 6, 2026
Merged

Fix changed-between dry-run range handling#3337
Widthdom merged 3 commits into
mainfrom
fix-issue2987-3046

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Added regression coverage that cdidx index --changed-between purges indexed rows for files deleted between refs, including +...md changelog fragment paths.
  • Updated dry-run changed-between candidate resolution so git range/ref failures return a usage error instead of silently producing an empty candidate set.
  • Stabilized retry cancellation tests after macOS/net9.0 CI exposed timing variance in the cancellation timer.
  • Added bilingual changelog fragments for both issues.

Validation

  • dotnet build -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~Run_UpdateMode_WithChangedBetween_RemovesDeletedPath_2987|FullyQualifiedName~Run_DryRun_WithChangedBetweenInvalidRef_ReturnsUsageError_3046" -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~OpenSqliteConnectionWithRetry_CancelDuringRetrySleep_ThrowsOperationCanceled|FullyQualifiedName~RegisterConnectionFunctionsWithRetry_CancelDuringRetrySleep_ThrowsOperationCanceled" -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --configuration Release --framework net9.0 --filter "FullyQualifiedName~OpenSqliteConnectionWithRetry_CancelDuringRetrySleep_ThrowsOperationCanceled|FullyQualifiedName~RegisterConnectionFunctionsWithRetry_CancelDuringRetrySleep_ThrowsOperationCanceled" -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Codex adversarial review: No blocking/actionable issues found.

Documentation and changelog

  • changelog.d/unreleased/2987.fixed.md
  • changelog.d/unreleased/3046.fixed.md
  • No AGENTS.md, CLAUDE.md, or AGENT_GUIDE.md edits.

Notes

Fixes #2987
Fixes #3046

@Widthdom
Widthdom marked this pull request as ready for review June 6, 2026 17:37
@Widthdom
Widthdom merged commit e29024e into main Jun 6, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2987-3046 branch June 6, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dry-run changed-between should report git range failures Delta indexing should purge files deleted between refs

1 participant