Skip to content

Cap detailed diff row field output - #3355

Merged
Widthdom merged 3 commits into
mainfrom
fix-issue3163
Jun 6, 2026
Merged

Cap detailed diff row field output#3355
Widthdom merged 3 commits into
mainfrom
fix-issue3163

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Cap oversized encoded field samples in cdidx diff --detailed rows and include original length plus a stable SHA-256 fingerprint.
  • Compare full row sort values directly so truncation does not hide drift and equal rows do not need display encoding.
  • Add regression coverage for large symbol signatures and large chunk content with shared display prefixes.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~DiffCommandRunnerTests
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Documentation and changelog

  • Added changelog.d/unreleased/3163.fixed.md.
  • No docs update: the detailed encoded row string format is not documented as a public contract outside changelog coverage.

Review

  • Adversarial review: No blocking/actionable issues found.
  • codex exec review --base origin/main was attempted but could not complete in this environment because nested shell calls failed repeatedly; the final origin/main..HEAD diff was reviewed manually under .codex/workflows/adversarial-review.md.

Follow-up candidates

  • None.

Fixes #3163

@Widthdom
Widthdom marked this pull request as ready for review June 6, 2026 19:58
@Widthdom
Widthdom merged commit 86759c6 into main Jun 6, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3163 branch June 9, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diff --detailed should cap encoded row text for large fields

1 participant