Skip to content

Harden suggestion store JSON permissions - #3356

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue3267
Jun 6, 2026
Merged

Harden suggestion store JSON permissions#3356
Widthdom merged 1 commit into
mainfrom
fix-issue3267

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Write primary suggestions-*.json stores through the existing atomic private-file mode callback path.
  • Add POSIX regression coverage for owner-only suggestion store files.
  • Document the suggestion store permission contract.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SuggestionStoreTests" -c Debug -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet build CodeIndex.sln -c Debug -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Codex adversarial review against origin/main..HEAD: no actionable correctness or regression issues found.

Documentation / Changelog

  • Updated DEVELOPER_GUIDE.md filesystem permissions contract in English and Japanese.
  • Added changelog fragment: changelog.d/unreleased/3267.security.md.

Scope

Fixes #3267

@Widthdom
Widthdom marked this pull request as ready for review June 6, 2026 20:01
@Widthdom
Widthdom merged commit 5d27777 into main Jun 6, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue3267 branch June 6, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion store JSON should be written with private permissions

1 participant