Expose search and excerpt JSON recovery metadata - #3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
No target issue was skipped for an existing work-start comment.
AGENT.md, CLAUDE.md, and AGENT_GUIDE.md were not modified.
Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSearch_JsonOutput_MatchesGolden" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~GitHelperTests.GetChangedFilesFromCommit_FailsWhenGitCommandTimesOut" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SearchSnippetFormatterTests|FullyQualifiedName~RunSearch_ExactSubstringJsonOutputsLiteralHighlightMetadata|FullyQualifiedName~RunSearch_ExactSubstringWithRawFtsReportsEffectiveLiteralHighlightMode_Issue3558|FullyQualifiedName~RunSearch_RawFtsJsonReportsLiteralHighlightGapMetadata_Issue3558|FullyQualifiedName~ToolsCall_Search_RawQuerySupportsFtsSyntax|FullyQualifiedName~ToolsCall_Search_ExactWithRawQueryReportsEffectiveLiteralHighlightMode_Issue3558|FullyQualifiedName~RunFind_JsonClampsLongSingleLineSnippet|FullyQualifiedName~RunFind_WithJsonOutputsLineColumnAndSnippet|FullyQualifiedName~RunFind_WithJsonReportsSpanMetadataForMultipleMatchesInOneFile_Issue3561|FullyQualifiedName~RunExcerpt_JsonClampsLongSingleLineContentAroundFocus|FullyQualifiedName~ToolsCall_Excerpt_ClampsLongSingleLineContent|FullyQualifiedName~RunDefinition_JsonBodyIncludesTruncationMetadata_Issue3131|FullyQualifiedName~RunDefinition_JsonBodyReportsByteCapRecovery_Issue3562|FullyQualifiedName~RunSearch_JsonOutput_MatchesGolden" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunInspect_JsonBodyRecoveryCommandIncludesActiveDb_Issue3562|FullyQualifiedName~RunSearch_RecipeJsonWithRawFtsReportsEffectiveSanitizedMode_Issue3558" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSearch_RecipeJsonRunsBuiltInQueries_Issue3144|FullyQualifiedName~RunSearch_RecipeJsonWithRawFtsReportsEffectiveSanitizedMode_Issue3558|FullyQualifiedName~RunSearch_ExactSubstringWithRawFtsReportsEffectiveLiteralHighlightMode_Issue3558|FullyQualifiedName~ToolsCall_Search_ExactWithRawQueryReportsEffectiveLiteralHighlightMode_Issue3558|FullyQualifiedName~RunInspect_JsonBodyRecoveryCommandIncludesActiveDb_Issue3562|FullyQualifiedName~RunDefinition_JsonBodyReportsByteCapRecovery_Issue3562|FullyQualifiedName~RunExcerpt_JsonClampsLongSingleLineContentAroundFocus|FullyQualifiedName~ToolsCall_Excerpt_ClampsLongSingleLineContent|FullyQualifiedName~ToolsCall_AnalyzeSymbol" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "ToolsCall_SearchRecipe_AppliesResultOutputMetadata_Issue3558|ToolsCall_Search_RawQuerySupportsFtsSyntax|ToolsCall_Search_ExactWithRawQueryReportsEffectiveLiteralHighlightMode_Issue3558|RunSearch_ExactSubstringWithRawFtsReportsEffectiveLiteralHighlightMode_Issue3558|RunSearch_RecipeJsonWithRawFtsReportsEffectiveSanitizedMode_Issue3558|RunInspect_JsonBodyRecoveryCommandIncludesActiveDb_Issue3562|RunDefinition_JsonBodyReportsByteCapRecovery_Issue3562" -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet build -p:UseSharedCompilation=false -m:1 /nodeReuse:falsedotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --commits HEAD --jsondotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false -m:1 /nodeReuse:falsewas attempted; the only failure wasQueryCommandRunnerTests.RunPublishedTrimmedCli_SerializesQueryJsonAndErrorJson, caused by missing local runtimeMicrosoft.NETCore.App 10.0.8-servicing.26229.119for ILLink 10.0.8.Adversarial Review
codex adversarial-review:No blocking/actionable issues found.codex adversarial-review: found and fixed MCP recipe result metadata defaulting.codex adversarial-review:No blocking/actionable issues found.Fixes #3556
Fixes #3557
Fixes #3558
Fixes #3561
Fixes #3562