Expand risky-code recipes and default audit scope - #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
risky-codewith dogfooding, C# smell, and security-focused audit queries.--audit-scope <source|all>for recipe runs and JSON metadata for the effective scope.--audit-scope allis used.Validation
dotnet build CodeIndex.sln -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSearch_Recipe|FullyQualifiedName~RunSearch_ListRecipes|FullyQualifiedName~ParseArgs_ParsesFiltersFlagsAndAcceptsMaxSnippetLines|FullyQualifiedName~PrintUsage_QueryLinesMatchImplementedOptions" -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~CliFlagSchemaTests" -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changesdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsongit diff --check;dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet test CodeIndex.sln -p:UseSharedCompilation=falsewas attempted on the final branch and stopped after more than 25 minutes without completion. A prior full-suite attempt in this workspace exposed the local trimmed-publish runtime issue tracked in Trimmed publish test fails when ILLink 10.0.8 requires unavailable .NET 10.0.8 runtime #3571.Docs / Changelog
USER_GUIDE.mdfor recipe scope behavior.changelog.d/unreleased/3385.added.md.Follow-up
Fixes #3385
Fixes #3387
Fixes #3390
Fixes #3440
Fixes #3448