Fix MCP argument contracts and batch limits - #3588
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludePaths, and compatible JSON type hints.warningsandargument_adjustments.batch_queryslot limits, response-budget controls, estimate mode, slot ids, and resumable truncation hints.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpToolContractTests|FullyQualifiedName~McpServerTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~Mcp"(via required Codex adversarial review)dotnet run --project tools/CodeIndex.Changelog -- checkgit diff --check origin/main..HEADdotnet format CodeIndex.sln --verify-no-changesdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo blocking/actionable issues found.Full
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csprojwas attempted locally earlier but cannot complete in this environment because the installed runtimes do not includeMicrosoft.NETCore.App 10.0.8-servicing.26229.119, which the current ILLink dependency asks for during publish-trimmed tests.Fixes #3538
Fixes #3436
Fixes #3539
Fixes #3406