Harden release workflow security - #3595
Merged
Merged
Conversation
…87-3489-3490-3491-3508
…87-3489-3490-3491-3508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet run --project tools/CodeIndex.Changelog -- checkdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -p:UseSharedCompilation=false --no-build --filter FullyQualifiedName~ReleaseWorkflowTestsNo blocking/actionable issues found.Full solution test was attempted but hit an unrelated local SDK/runtime mismatch in
RunPublishedTrimmedCli_SerializesQueryJsonAndErrorJson: ILLink 10.0.8 requiresMicrosoft.NETCore.App 10.0.8-servicing.26229.119, while this machine has 8.0.19, 9.0.5, 9.0.6, and 10.0.0.Changelog
changelog.d/unreleased/3485.security.mdchangelog.d/unreleased/3486.security.mdchangelog.d/unreleased/3487.security.mdchangelog.d/unreleased/3489.security.mdchangelog.d/unreleased/3490.security.mdchangelog.d/unreleased/3491.security.mdchangelog.d/unreleased/3508.security.mdIssues
Fixes #3485
Fixes #3486
Fixes #3487
Fixes #3489
Fixes #3490
Fixes #3491
Fixes #3508
Notes
No target issue had an existing work-started comment when checked, so none were excluded.